[PATCH] D147763: [ARM] Emit code alignment after .arm and .thumb directives

[Antonio Abbatangelo via Phabricator via llvm-commits]

antangelo updated this revision to Diff 526242.
antangelo added a comment.

Rebase and addressing feedback

Updated the release notes syntax, fixed the directive-arm-thumb-alignment test file name,
and added tests for section alignment.

After studying the tests again more closely, to my understanding, the nopatch tests
are for edge cases where the fix should not be applied, so having the same result when `--fix-cortex-a8`
is removed seems to be correct. I also noticed a bug where the nop.w instruction that is manually
encoded in that test is encoded incorrectly, so I have updated that. If the `.arm` directive
under target5 is removed, the case is now detected as requiring the cortex-a8 fix (so it is now testing
the right thing).

I have verified the offsets in both the nopatch and recognize suites and they match what is currently
in main (and match the condition that triggers the fix). I don't otherwise know what to look for in
terms of what could be incorrect there. Is there anything about those tests in particular that need updating,
or something else I should verify against?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147763/new/

https://reviews.llvm.org/D147763

Files:
  lld/test/ELF/arm-bl-v4t.s
  lld/test/ELF/arm-bl-v6-inrange.s
  lld/test/ELF/arm-fix-cortex-a8-nopatch.s
  lld/test/ELF/arm-fix-cortex-a8-recognize.s
  lld/test/ELF/arm-thunk-multipass.s
  llvm/docs/ReleaseNotes.rst
  llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  llvm/test/MC/ARM/directive-arch-mode-switch.s
  llvm/test/MC/ARM/directive-arm-thumb-alignment.s
  llvm/test/MC/ARM/misaligned-blx.s
  llvm/test/MC/ARM/thumb-function-address.s
  llvm/test/MC/ARM/thumb-types.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147763.526242.patch
Type: text/x-patch
Size: 11679 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230527/6c0be7c9/attachment.bin>