[PATCH] D147763: [ARM] Emit code alignment after .arm and .thumb directives
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 27 18:50:54 PDT 2023
MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/test/MC/ARM/directive-arm-thumb-alignment.s:5
+@ CHECK-NEXT: [ 0] NULL 00000000 000000 000000 00 0 0 0
+@ CHECK-NEXT: [ 1] .strtab STRTAB 00000000 00012c 0000b7 00 0 0 1
+@ CHECK-NEXT: [ 2] .text PROGBITS 00000000 000034 00000d 00 AX 0 0 4
----------------
Replace `Off` column values with `{{.*}}`. The offsets are not interesting for the purpose of the test and will cause unneeded trouble for changes that shuffle section order/string table optimization/etc, see https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-too-much .
Replace `Size` column value of `.strtab` with `{{.*}}`
================
Comment at: llvm/test/MC/ARM/directive-arm-thumb-alignment.s:64
+ nop
+
----------------
Delete trailing blan lines
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147763/new/
https://reviews.llvm.org/D147763
More information about the llvm-commits
mailing list