[PATCH] D147794: [mlgo][inl] Interactive mode: optionally tell the default decision

[Mircea Trofin via llvm-commits]

Oh - duh. Thank you!


On Mon, Apr 10, 2023 at 11:27 PM Mehdi AMINI via Phabricator <
reviews at reviews.llvm.org> wrote:

> mehdi_amini added inline comments.
>
>
> ================
> Comment at: llvm/lib/Analysis/MLInlineAdvisor.cpp:46
> +         DefaultDecisionName + ".")
> +            .str()));
>
> ----------------
> This leads to a use-after-free: you're creating a temporary string that is
> immediately destroyed but referenced through a StringRef when printing the
> help.
>
> I pushed a quick fix in 437dfa5b0365 but you may want to tweak this.
>
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D147794/new/
>
> https://reviews.llvm.org/D147794
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230411/ac21323f/attachment.html>