[PATCH] D147794: [mlgo][inl] Interactive mode: optionally tell the default decision

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 10 23:27:12 PDT 2023


mehdi_amini added inline comments.


================
Comment at: llvm/lib/Analysis/MLInlineAdvisor.cpp:46
+         DefaultDecisionName + ".")
+            .str()));
 
----------------
This leads to a use-after-free: you're creating a temporary string that is immediately destroyed but referenced through a StringRef when printing the help. 

I pushed a quick fix in 437dfa5b0365 but you may want to tweak this.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147794/new/

https://reviews.llvm.org/D147794



More information about the llvm-commits mailing list