<div dir="ltr">Oh - duh. Thank you!</div><div><br></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 10, 2023 at 11:27 PM Mehdi AMINI via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">mehdi_amini added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/lib/Analysis/MLInlineAdvisor.cpp:46<br>
+         DefaultDecisionName + ".")<br>
+            .str()));<br>
<br>
----------------<br>
This leads to a use-after-free: you're creating a temporary string that is immediately destroyed but referenced through a StringRef when printing the help. <br>
<br>
I pushed a quick fix in 437dfa5b0365 but you may want to tweak this.<br>
<br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D147794/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D147794/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D147794" rel="noreferrer" target="_blank">https://reviews.llvm.org/D147794</a><br>
<br>
</blockquote></div></div>