[PATCH] D147096: AMDGPU: Created a sub-register class for the return address operand in the tail call return instruction

[Changpeng Fang via Phabricator via llvm-commits]

cfang added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:2490
+  if (!B.getMRI()->getRegClassOrNull(PCReg))
+    B.getMRI()->setRegClass(PCReg, &AMDGPU::SReg_64RegClass);
 
----------------
arsenm wrote:
> cdevadas wrote:
> > Not sure this is the right thing to do. @foad can you review this?
> Looking at the test diffs, I think we should introduce a copy to the correct register class when TCRETURN is inserted. If the G_GLOBAL_VALUE has other uses, it's over constrained
I would say the test diff you saw is from different places even though here we may have the same issue. I plan to commit as it is for now.
and continue to investigate the performance issue related to the regClass change. Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147096/new/

https://reviews.llvm.org/D147096