[PATCH] D144070: [llvm][GenericUniformity] Prevent assert while calculating temporal divergence

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 15 06:57:01 PST 2023


sameerds added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineUniformityAnalysis.cpp:108
+    // assert(Reg.isVirtual());
+    if (Reg.isPhysical())
+      continue;
----------------
What does it mean to continue here? Is it true that a physical register cannot be written inside the cycle? A comment explaining why will be useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144070/new/

https://reviews.llvm.org/D144070



More information about the llvm-commits mailing list