[PATCH] D144070: [llvm][GenericUniformity] Prevent assert while calculating temporal divergence

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineUniformityAnalysis.cpp:107
+    // FIXME: Physical registers need to be checked separately
+    // assert(Reg.isVirtual());
+    if (Reg.isPhysical())
----------------
Remove dead assert


================
Comment at: llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/uses-value-from-cycle.mir:4
+--- |
+  define amdgpu_cs void @f2() #0 {
+  bb:
----------------
Shouldn't need IR section?


================
Comment at: llvm/test/Analysis/DivergenceAnalysis/AMDGPU/MIR/uses-value-from-cycle.mir:137-157
+    %26:_(p4) = G_CONSTANT i64 36
+    %29:_(s64) = G_IMPLICIT_DEF
+    %30:_(s32) = G_IMPLICIT_DEF
+    %43:_(s32) = G_CONSTANT i32 0
+    $vgpr0 = COPY %43(s32)
+    $vgpr1 = COPY %43(s32)
+    $vgpr2 = COPY %43(s32)
----------------
Surely you don't need all these arguments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144070/new/

https://reviews.llvm.org/D144070