[PATCH] D142021: AMDGPU/GlobalISel: Add stub custom regbankselect pass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 11:11:12 PST 2023


arsenm added a comment.

In D142021#4064815 <https://reviews.llvm.org/D142021#4064815>, @Pierre-vh wrote:

> I agree that the commit message should have a rationale for this change
>
> Also, now that we need to pass amdgpu-regbankselect, what happens if someone just passes regbankselect? 💥 ?

It will just be broken in the same way it’s broken today. Running arbitrary MIR passes isn’t supposed to be a production ready, end user exposed feature in the same way as an IR pass so I’m not too worried about diagnosing this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142021/new/

https://reviews.llvm.org/D142021



More information about the llvm-commits mailing list