[PATCH] D142021: AMDGPU/GlobalISel: Add stub custom regbankselect pass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D142021#4064779 <https://reviews.llvm.org/D142021#4064779>, @rovka wrote:

> Why do we need a new pass? Could we achieve the same goals with a new RegBankSelect mode instead? (Sorry if this was discussed somewhere else and I missed it, in any case I think the commit message should either explain the rationale or point to wherever it's been discussed)

I believe the mode is an orthogonal choice, which is part of why I am trying to subclass the existing pass. We could have the same use and def analysis like other targets with the different modes, but the uniformity driven decisions are more fundamental. Additionally this needs to be a separate pass because it introduces new required analysis passes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142021/new/

https://reviews.llvm.org/D142021