[PATCH] D142021: AMDGPU/GlobalISel: Add stub custom regbankselect pass

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

I agree that the commit message should have a rationale for this change

Also, now that we need to pass amdgpu-regbankselect, what happens if someone just passes regbankselect? 💥 ?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPURegBankSelect.h:10
+/// This file declares the targeting of the InstructionSelector class for
+/// AMDGPU.
+//===----------------------------------------------------------------------===//
----------------
rovka wrote:
> Update this comment for RegBankSelect instead of InstructionSelector (ditto for the header guard)
It would be nice to explain why this custom pass is actually needed. If it's a stub then just say it's a stub but it's been added because it makes X or Y possible later for instance;
Otherwise it's difficult to understand why it's needed and someone might try to remove it later


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142021/new/

https://reviews.llvm.org/D142021