[PATCH] D141036: [JITLink] Add an initial implementation of JITLink for ELF/LoongArch

[WÁNG Xuěruì via Phabricator via llvm-commits]

xen0n added a comment.

The architecture-specific details LGTM, thanks! A couple of nits below.



================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/loongarch.h:272
+///   ld.[w/d]  $r20, %pageoff12(ptr)
+///   jr        $r20
+constexpr size_t StubEntrySize = 12;
----------------
nit: `$t8` for better readability


================
Comment at: llvm/lib/Target/LoongArch/TargetInfo/LoongArchTargetInfo.cpp:24
 extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeLoongArchTargetInfo() {
   RegisterTarget<Triple::loongarch32, /*HasJIT=*/false> X(
       getTheLoongArch32Target(), "loongarch32", "32-bit LoongArch",
----------------
Why not adjust this too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141036/new/

https://reviews.llvm.org/D141036