[PATCH] D141036: [JITLink] Add an initial implementation of JITLink for ELF/LoongArch

[wanglei via Phabricator via llvm-commits]

wangleiat added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/JITLink/loongarch.h:272
+///   ld.[w/d]  $r20, %pageoff12(ptr)
+///   jr        $r20
+constexpr size_t StubEntrySize = 12;
----------------
xen0n wrote:
> nit: `$t8` for better readability
> nit: `$t8` for better readability

Thanks.


================
Comment at: llvm/lib/Target/LoongArch/TargetInfo/LoongArchTargetInfo.cpp:24
 extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeLoongArchTargetInfo() {
   RegisterTarget<Triple::loongarch32, /*HasJIT=*/false> X(
       getTheLoongArch32Target(), "loongarch32", "32-bit LoongArch",
----------------
xen0n wrote:
> Why not adjust this too?
> Why not adjust this too?

Although both `loongarch32` and `loongarch64` are processed in the code, I don't have a real environment to verify `loongarch32`, so I conservatively set `loongarch32` to false here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141036/new/

https://reviews.llvm.org/D141036