[PATCH] D141036: [JITLink] Add an initial implementation of JITLink for ELF/LoongArch

Mon Jan 16 23:00:46 PST 2023

wangleiat added a comment.

In D141036#4057705 <https://reviews.llvm.org/D141036#4057705>, @lhames wrote:

> I can't speak to the architecture specific details as I don't know Loongarch, but if the tests are passing this looks excellent to me -- The layout and style fits very well with the existing backends.
>
> Do you have commit access?

Yes, I have. Thank you very much for your comments.

================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF.cpp:93-94
     return;
+  case Triple::loongarch32:
+  case Triple::loongarch64:
+    link_ELF_loongarch(std::move(G), std::move(Ctx));
----------------
lhames wrote:
> Looks like the new backend will handle both `loongarch32` and `loongarch64`. Are there any differences at the linker level?
They are no different, `loongarch32`'s relocation type is a subset of `loongarch64`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141036/new/

https://reviews.llvm.org/D141036