[PATCH] D140820: [JITLink][RISCV] Homogenize immediate handling

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 1 20:16:34 PST 2023


StephenFan accepted this revision.
StephenFan added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks!



================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:228
       uint32_t RawInstr = *(little32_t *)FixupPtr;
-      *(little32_t *)FixupPtr = RawInstr | Imm20 | Imm10_1 | Imm11 | Imm19_12;
+      *(little32_t *)FixupPtr =
+          (RawInstr & 0xFFF) | Imm20 | Imm10_1 | Imm11 | Imm19_12;
----------------
It's better to change this in another commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140820/new/

https://reviews.llvm.org/D140820



More information about the llvm-commits mailing list