[PATCH] D140820: [JITLink][RISCV] Homogenize immediate handling
Jonas Hahnfeld via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 1 14:13:12 PST 2023
Hahnfeld added a comment.
I have to confess that the previous way of specifying the arguments to `extractBits` (before rG95b74d4db0686a8d55fdae1af4e985ea52b2c572 <https://reviews.llvm.org/rG95b74d4db0686a8d55fdae1af4e985ea52b2c572>) was slightly more convenient because we could just copy from the spec. I personally find this new variable naming more logical, but please let me know what you think. Ideally, we could either share this immediate handling with LLD or directly extract it from the instruction encoding that LLVM knows about anyway.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140820/new/
https://reviews.llvm.org/D140820
More information about the llvm-commits
mailing list