[PATCH] D116463: [SPIRV 4/6] Add target lowering, TargetMachine and AsmPrinter

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp:44
+  uint32_t FuncControl = 0;
+  return FuncControl;
+}
----------------
Just return 0.

Is this stub necessary?


================
Comment at: llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp:55
+  if (VRegs.size() > 0) {
+    unsigned int i = 0;
+    for (const auto &Arg : F.args()) {
----------------
s/unsigned int/unsigned/g

This applies to many files.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp:15
+#include "SPIRV.h"
+//#include "llvm/IR/IntrinsicsSPIRV.h"
+
----------------
delete


================
Comment at: llvm/lib/Target/SPIRV/SPIRVMCInstLower.cpp:30
+    default:
+      MI->print(errs());
+      llvm_unreachable("unknown operand type");
----------------
Delete `print` in the unreachable branch.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVMCInstLower.h:21
+public:
+  void Lower(const MachineInstr *MI, MCInst &OutMI) const;
+};
----------------
`lower`


================
Comment at: llvm/lib/Target/SPIRV/SPIRVRegisterInfo.cpp:26
+  BitVector Reserved(getNumRegs());
+  return Reserved;
+}
----------------
`return BitVector(getNumRegs())`


================
Comment at: llvm/lib/Target/SPIRV/SPIRVTargetMachine.cpp:111
+void SPIRVPassConfig::addPostRegAlloc() {
+  // Do not work with vregs instead of physical regs
+  disablePass(&MachineCopyPropagationID);
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116463/new/

https://reviews.llvm.org/D116463