[PATCH] D116463: [SPIRV 4/6] Add target lowering, TargetMachine and AsmPrinter

[Ilia Diachkov via Phabricator via llvm-commits]

iliya-diyachkov added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp:44
+  uint32_t FuncControl = 0;
+  return FuncControl;
+}
----------------
MaskRay wrote:
> Just return 0.
> 
> Is this stub necessary?
This stub is filled in the 5th patch. Since this is confusing, I'll remove it here and add it in the 5th patch.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp:55
+  if (VRegs.size() > 0) {
+    unsigned int i = 0;
+    for (const auto &Arg : F.args()) {
----------------
MaskRay wrote:
> s/unsigned int/unsigned/g
> 
> This applies to many files.
Ok, I'll fix it in all files.


================
Comment at: llvm/lib/Target/SPIRV/SPIRVISelLowering.cpp:15
+#include "SPIRV.h"
+//#include "llvm/IR/IntrinsicsSPIRV.h"
+
----------------
MaskRay wrote:
> delete
Sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116463/new/

https://reviews.llvm.org/D116463