[PATCH] D116464: [SPIRV 5/6] Add LegalizerInfo, InstructionSelector and utilities

Ilia Diachkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 27 19:33:27 PDT 2022


iliya-diyachkov marked an inline comment as done.
iliya-diyachkov added inline comments.


================
Comment at: llvm/lib/Target/SPIRV/MCTargetDesc/SPIRVBaseInfo.h:25
+namespace Capability {
+enum Capability : uint32_t {
+  Matrix = 0,
----------------
MaskRay wrote:
> `namespace XXX { enum XXX { ... } }`` can usually be replaced with `enum class XXX {...}`
Thanks, @MaskRay. The code is corrected.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116464/new/

https://reviews.llvm.org/D116464



More information about the llvm-commits mailing list