[PATCH] D122251: [lit] Use sharding for GoogleTest format

Wed Mar 23 12:06:31 PDT 2022

ychen added a comment.

In D122251#3403337 <https://reviews.llvm.org/D122251#3403337>, @probinson wrote:

> In D122251#3401008 <https://reviews.llvm.org/D122251#3401008>, @ychen wrote:
>
>> Do we support using upstream googletest instead of the in-tree copy for the unit test?
>
> The Clang/LLVM unittests use an imported copy of googletest (with some modifications, I believe mainly to allow using LLVM's various string types with gtest macros).  However, I think I have seen patches intended to allow lit to work cleanly with upstream googletest.  That functionality should be preserved, even though LLVM itself doesn't make use of it.

Agreed. I think they're preserved. The deleted tests are meant for a piece of deleted code.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251