[PATCH] D122251: [lit] Use sharding for GoogleTest format

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 23 11:48:46 PDT 2022


probinson added a comment.

In D122251#3401008 <https://reviews.llvm.org/D122251#3401008>, @ychen wrote:

> Do we support using upstream googletest instead of the in-tree copy for the unit test?

The Clang/LLVM unittests use an imported copy of googletest (with some modifications, I believe mainly to allow using LLVM's various string types with gtest macros).  However, I think I have seen patches intended to allow lit to work cleanly with upstream googletest.  That functionality should be preserved, even though LLVM itself doesn't make use of it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251



More information about the llvm-commits mailing list