[PATCH] D122251: [lit] Use sharding for GoogleTest format

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Re. performance, I can see the benefit if you just run the unit tests, but is that the normal use-case? My suspicion is that most peopke just run check-llvm or check-clang, which includes the regular lit tests, and therefore already ends up with things split across he available cores. Do you have any figures for that case?



================
Comment at: llvm/utils/lit/lit/main.py:143-144
+                idxs.append(idx)
+        for i in range(len(idxs)):
+            del tests[idxs[i]-i]
+
----------------
Doesn't this invalidate the indexes after the first one? If we need to delete items 2 and 4 in the list, after deleting item 2, item 4 will be at index 3 now.


================
Comment at: llvm/utils/lit/lit/main.py:151
+        # Load json file to retrieve results.
+        with open(test.gtest_json_file, encoding='utf-8') as file:
+            testsuites = json.load(file)['testsuites']
----------------
Don't use `file` as a variable name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251