[PATCH] Fix TableGen -gen-disassembler output for certain bit field definitions.
Craig Topper
craig.topper at gmail.com
Thu Sep 25 23:13:47 PDT 2014
LGTM. Though I wonder if the if and else couldn't be better combined.
On Thu, Sep 25, 2014 at 8:07 PM, Steve King <kingshizzle at gmail.com> wrote:
> TableGen -gen-disassembler extracts incorrect operand values for certain
> bit fields with an offset. The result is that disassembly silently fails
> with incorrect operand values. Bit assignments like:
> Inst{7-0} = Foo{9-2}
> are vulnerable to this problem.
>
> http://reviews.llvm.org/D5498
>
> Files:
> test/TableGen/BitShiftDecoder.td
> utils/TableGen/FixedLenDecoderEmitter.cpp
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
--
~Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140925/52ba18be/attachment.html>
More information about the llvm-commits
mailing list