<div dir="ltr">LGTM. Though I wonder if the if and else couldn't be better combined.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 25, 2014 at 8:07 PM, Steve King <span dir="ltr"><<a href="mailto:kingshizzle@gmail.com" target="_blank">kingshizzle@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">TableGen -gen-disassembler extracts incorrect operand values for certain bit fields with an offset.  The result is that disassembly silently fails with incorrect operand values.  Bit assignments like:<br>
Inst{7-0} = Foo{9-2}<br>
are vulnerable to this problem.<br>
<br>
<a href="http://reviews.llvm.org/D5498" target="_blank">http://reviews.llvm.org/D5498</a><br>
<br>
Files:<br>
  test/TableGen/BitShiftDecoder.td<br>
  utils/TableGen/FixedLenDecoderEmitter.cpp<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig
</div>