[PATCH] Tweaks for constant-equality-comparisons in BPI

Chandler Carruth chandlerc at google.com
Wed Oct 30 16:44:01 PDT 2013


On Wed, Oct 30, 2013 at 2:48 PM, Hal Finkel <hfinkel at anl.gov> wrote:

> My best statistical evidence supports keeping the current behavior for (x
> ==/!= 0) (so doing nothing different for the power-of-two case), and
> committing the (x ==/!= -1) change (which gives a measurable speedup).
>
> I'd also like to commit the error-reporting-functions-as-cold-functions
> change (the patch from the other e-mail); I see no changes in the test
> suite, but that helps mostly for debugging (when people add conditional
> fprintf(stderr, ...) into hot parts of the code).
>

Please commit. I've not reviewed the code for the second
error-reporting-functions bit, but I can do that post-commit, it seems
obvious and unconcerning.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131030/651a64fe/attachment.html>


More information about the llvm-commits mailing list