[PATCH] Tweaks for constant-equality-comparisons in BPI

Renato Golin renato.golin at linaro.org
Wed Oct 30 15:39:10 PDT 2013


On 30 October 2013 14:48, Hal Finkel <hfinkel at anl.gov> wrote:

> My best statistical evidence supports keeping the current behavior for (x
> ==/!= 0) (so doing nothing different for the power-of-two case), and
> committing the (x ==/!= -1) change (which gives a measurable speedup).
>

Unless someone feels strongly against it, I'm fine with it. Thanks for
doing the extra research.


I'd also like to commit the error-reporting-functions-as-cold-functions
> change (the patch from the other e-mail); I see no changes in the test
> suite, but that helps mostly for debugging (when people add conditional
> fprintf(stderr, ...) into hot parts of the code).
>

I replied to your email directly, but essentially, that's also fine by me.

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131030/5fe17e89/attachment.html>


More information about the llvm-commits mailing list