[PATCH] Tweaks for constant-equality-comparisons in BPI

Hal Finkel hfinkel at anl.gov
Fri Nov 1 04:07:53 PDT 2013


----- Original Message -----
> 
> 
> 
> 
> On Wed, Oct 30, 2013 at 2:48 PM, Hal Finkel < hfinkel at anl.gov >
> wrote:
> 
> 
> 
> My best statistical evidence supports keeping the current behavior
> for (x ==/!= 0) (so doing nothing different for the power-of-two
> case), and committing the (x ==/!= -1) change (which gives a
> measurable speedup).
> 
> I'd also like to commit the
> error-reporting-functions-as-cold-functions change (the patch from
> the other e-mail); I see no changes in the test suite, but that
> helps mostly for debugging (when people add conditional
> fprintf(stderr, ...) into hot parts of the code).
> Please commit. 

The (x == -1) part has been committed in r193855. Thanks!

 -Hal

> I've not reviewed the code for the second
> error-reporting-functions bit, but I can do that post-commit, it
> seems obvious and unconcerning.

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list