[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

[via llvm-branch-commits]

================
@@ -45,6 +45,8 @@ namespace opts {
 
 extern cl::opt<bool> TimeRewrite;
 extern cl::OptionCategory BoltOptCategory;
+extern cl::opt<unsigned> Verbosity;
+extern cl::opt<bool> ProfileUsePseudoProbes;
----------------
WenleiHe wrote:

> If the profile contains probe information, but ProfileUsePseudoProbes is not set, we will not use the information for matching.

But this is the confusion... The profile (not stale matching) is clearly using probe as probe exists in profile, why you want users to use such a flag (set to false) to control stale matching strategy. Wouldn't it be better to have a dedicated flag whose name actually reflects its purpose in this case? 

https://github.com/llvm/llvm-project/pull/99891