[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

Amir Ayupov via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Jul 24 14:43:02 PDT 2024


================
@@ -45,6 +45,8 @@ namespace opts {
 
 extern cl::opt<bool> TimeRewrite;
 extern cl::OptionCategory BoltOptCategory;
+extern cl::opt<unsigned> Verbosity;
+extern cl::opt<bool> ProfileUsePseudoProbes;
----------------
aaupov wrote:

> Ok, I think we need a dedicated flag to control matching strategy, otherwise it can be confusing. Generating profile with probe and using profile for stale profile matching are two different things.

Agree they're different but both require parsing pseudo probes, which is controlled by the flag. `ProfileUseDFS` is another flag which controls both profile generation and consumption.

> Like profile contains probe doesn't mean stale matching has to use probe.

If the profile contains probe information, but ProfileUsePseudoProbes is not set, we will not use the information for matching.

https://github.com/llvm/llvm-project/pull/99891


More information about the llvm-branch-commits mailing list