[Lldb-commits] [lldb] [lldb][windows] relax TestMissingDll.py assert (PR #199046)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

The lldb-server path wraps the underlying error with `Cannot launch '<path>': `, while the in-process ProcessWindows plugin returns the bare error string. Relax the assert so that the test passes with or without `LLDB_USE_LLDB_SERVER=1`.

rdar://177623653

---
Full diff: https://github.com/llvm/llvm-project/pull/199046.diff


1 Files Affected:

- (modified) lldb/test/API/windows/launch/missing-dll/TestMissingDll.py (+2-1) 


``````````diff
diff --git a/lldb/test/API/windows/launch/missing-dll/TestMissingDll.py b/lldb/test/API/windows/launch/missing-dll/TestMissingDll.py
index 32fc266c0fde6..d1e972c7f0bcb 100644
--- a/lldb/test/API/windows/launch/missing-dll/TestMissingDll.py
+++ b/lldb/test/API/windows/launch/missing-dll/TestMissingDll.py
@@ -25,4 +25,5 @@ def test(self):
 
         error = lldb.SBError()
         target.Launch(launch_info, error)
-        self.assertFailure(error, "Process prematurely exited with 0xc0000135")
+        self.assertFalse(error.Success(), "expected launch to fail")
+        self.assertIn("Process prematurely exited with 0xc0000135", error.GetCString())

``````````

</details>


https://github.com/llvm/llvm-project/pull/199046