[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 24 15:57:10 PDT 2023


mib marked 5 inline comments as done.
mib added inline comments.


================
Comment at: lldb/source/Breakpoint/Watchpoint.cpp:140-141
+
+  LLDB_LOGF(log, "Watchpoint::%s called by breakpoint %" PRIu64 ".%" PRIu64,
+            __FUNCTION__, break_id, break_loc_id);
+
----------------
bulbazord wrote:
> Any reason to not use `LLDB_LOG` here? You'll get `__FILE__` and `__FUNCTION__` included.
I just wanted to stay consistent with the rest of the file. May we be should standardize the logging format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151366/new/

https://reviews.llvm.org/D151366



More information about the lldb-commits mailing list