[Lldb-commits] [lldb] 9916633 - [lldb] Fix modernize-use-override warnings (NFC)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Fri Jun 17 15:08:08 PDT 2022
Author: Jonas Devlieghere
Date: 2022-06-17T15:08:02-07:00
New Revision: 991663399792d4cc03da6b6c7131a6c213655318
URL: https://github.com/llvm/llvm-project/commit/991663399792d4cc03da6b6c7131a6c213655318
DIFF: https://github.com/llvm/llvm-project/commit/991663399792d4cc03da6b6c7131a6c213655318.diff
LOG: [lldb] Fix modernize-use-override warnings (NFC)
Fix modernize-use-override warnings. Because this check is listed in
LLDB's top level .clang-tidy configuration, the check is enabled by
default and the resulting warnings show up in my editor.
I've audited the modified lines. This is not a blind change.
Added:
Modified:
lldb/include/lldb/Core/DebuggerEvents.h
lldb/include/lldb/Core/ValueObjectDynamicValue.h
lldb/include/lldb/Host/File.h
lldb/include/lldb/Symbol/SymbolFileOnDemand.h
lldb/include/lldb/Target/LanguageRuntime.h
lldb/include/lldb/Target/SystemRuntime.h
lldb/include/lldb/Target/Target.h
lldb/include/lldb/Utility/DataBuffer.h
lldb/source/Host/macosx/cfcpp/CFCBundle.h
lldb/source/Host/macosx/cfcpp/CFCData.h
lldb/source/Host/macosx/cfcpp/CFCMutableArray.h
lldb/source/Host/macosx/cfcpp/CFCMutableDictionary.h
lldb/source/Host/macosx/cfcpp/CFCMutableSet.h
lldb/source/Host/macosx/cfcpp/CFCString.h
lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
lldb/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h
lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.h
lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h
lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.h
lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm.h
lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm64.h
lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_i386.h
lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_x86_64.h
lldb/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.h
lldb/source/Plugins/Process/Utility/RegisterContextMach_arm.h
lldb/source/Plugins/Process/Utility/RegisterContextMach_i386.h
lldb/source/Plugins/Process/Utility/RegisterContextMach_x86_64.h
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h
Removed:
################################################################################
diff --git a/lldb/include/lldb/Core/DebuggerEvents.h b/lldb/include/lldb/Core/DebuggerEvents.h
index b1ddb1fc47e2d..df64798db2316 100644
--- a/lldb/include/lldb/Core/DebuggerEvents.h
+++ b/lldb/include/lldb/Core/DebuggerEvents.h
@@ -57,7 +57,7 @@ class DiagnosticEventData : public EventData {
DiagnosticEventData(Type type, std::string message, bool debugger_specific)
: m_message(std::move(message)), m_type(type),
m_debugger_specific(debugger_specific) {}
- ~DiagnosticEventData() {}
+ ~DiagnosticEventData() override {}
const std::string &GetMessage() const { return m_message; }
bool IsDebuggerSpecific() const { return m_debugger_specific; }
diff --git a/lldb/include/lldb/Core/ValueObjectDynamicValue.h b/lldb/include/lldb/Core/ValueObjectDynamicValue.h
index 09dcd0f968be4..a36db44f449ac 100644
--- a/lldb/include/lldb/Core/ValueObjectDynamicValue.h
+++ b/lldb/include/lldb/Core/ValueObjectDynamicValue.h
@@ -32,7 +32,7 @@ class Status;
/// set lldb type.
class ValueObjectDynamicValue : public ValueObject {
public:
- ~ValueObjectDynamicValue() = default;
+ ~ValueObjectDynamicValue() override = default;
llvm::Optional<uint64_t> GetByteSize() override;
diff --git a/lldb/include/lldb/Host/File.h b/lldb/include/lldb/Host/File.h
index d10ec1fe282a1..85e8185ebc966 100644
--- a/lldb/include/lldb/Host/File.h
+++ b/lldb/include/lldb/Host/File.h
@@ -410,7 +410,7 @@ class NativeFile : public File {
llvm::Expected<OpenOptions> GetOptions() const override;
static char ID;
- virtual bool isA(const void *classID) const override {
+ bool isA(const void *classID) const override {
return classID == &ID || File::isA(classID);
}
static bool classof(const File *file) { return file->isA(&ID); }
@@ -458,7 +458,7 @@ class SerialPort : public NativeFile {
Status Close() override;
static char ID;
- virtual bool isA(const void *classID) const override {
+ bool isA(const void *classID) const override {
return classID == &ID || File::isA(classID);
}
static bool classof(const File *file) { return file->isA(&ID); }
diff --git a/lldb/include/lldb/Symbol/SymbolFileOnDemand.h b/lldb/include/lldb/Symbol/SymbolFileOnDemand.h
index ad2a999080864..e47872c9761c6 100644
--- a/lldb/include/lldb/Symbol/SymbolFileOnDemand.h
+++ b/lldb/include/lldb/Symbol/SymbolFileOnDemand.h
@@ -43,7 +43,7 @@ class SymbolFileOnDemand : public lldb_private::SymbolFile {
/// \}
SymbolFileOnDemand(std::unique_ptr<SymbolFile> &&symbol_file);
- virtual ~SymbolFileOnDemand() override;
+ ~SymbolFileOnDemand() override;
// PluginInterface protocol
llvm::StringRef GetPluginName() override { return "ondemand"; }
diff --git a/lldb/include/lldb/Target/LanguageRuntime.h b/lldb/include/lldb/Target/LanguageRuntime.h
index ba96d080f908d..0cdb02a449017 100644
--- a/lldb/include/lldb/Target/LanguageRuntime.h
+++ b/lldb/include/lldb/Target/LanguageRuntime.h
@@ -154,7 +154,7 @@ class LanguageRuntime : public Runtime, public PluginInterface {
return llvm::None;
}
- virtual void ModulesDidLoad(const ModuleList &module_list) override {}
+ void ModulesDidLoad(const ModuleList &module_list) override {}
// Called by ClangExpressionParser::PrepareForExecution to query for any
// custom LLVM IR passes that need to be run before an expression is
diff --git a/lldb/include/lldb/Target/SystemRuntime.h b/lldb/include/lldb/Target/SystemRuntime.h
index 0ec0793e95f9b..66868e474c6f4 100644
--- a/lldb/include/lldb/Target/SystemRuntime.h
+++ b/lldb/include/lldb/Target/SystemRuntime.h
@@ -77,7 +77,7 @@ class SystemRuntime : public Runtime, public PluginInterface {
///
/// Allow the SystemRuntime plugin to enable logging features in the system
/// runtime libraries.
- virtual void ModulesDidLoad(const ModuleList &module_list) override;
+ void ModulesDidLoad(const ModuleList &module_list) override;
/// Called before detaching from a process.
///
diff --git a/lldb/include/lldb/Target/Target.h b/lldb/include/lldb/Target/Target.h
index fb2914064ce45..53fe4831b82fa 100644
--- a/lldb/include/lldb/Target/Target.h
+++ b/lldb/include/lldb/Target/Target.h
@@ -1289,7 +1289,7 @@ class Target : public std::enable_shared_from_this<Target>,
class StopHookCommandLine : public StopHook {
public:
- virtual ~StopHookCommandLine() = default;
+ ~StopHookCommandLine() override = default;
StringList &GetCommands() { return m_commands; }
void SetActionFromString(const std::string &strings);
@@ -1312,7 +1312,7 @@ class Target : public std::enable_shared_from_this<Target>,
class StopHookScripted : public StopHook {
public:
- virtual ~StopHookScripted() = default;
+ ~StopHookScripted() override = default;
StopHookResult HandleStop(ExecutionContext &exc_ctx,
lldb::StreamSP output) override;
diff --git a/lldb/include/lldb/Utility/DataBuffer.h b/lldb/include/lldb/Utility/DataBuffer.h
index c52c7e0e10a0c..e1c66fae7453a 100644
--- a/lldb/include/lldb/Utility/DataBuffer.h
+++ b/lldb/include/lldb/Utility/DataBuffer.h
@@ -96,7 +96,7 @@ class WritableDataBuffer : public DataBuffer {
/// and be downcast to the DataBuffer pure virtual interface. The virtual
/// destructor ensures that destructing the base class will destruct the
/// class that inherited from it correctly.
- virtual ~WritableDataBuffer() = default;
+ ~WritableDataBuffer() override = default;
using DataBuffer::GetBytes;
using DataBuffer::GetData;
diff --git a/lldb/source/Host/macosx/cfcpp/CFCBundle.h b/lldb/source/Host/macosx/cfcpp/CFCBundle.h
index 8c56a5f37fc4d..398817fd87d3c 100644
--- a/lldb/source/Host/macosx/cfcpp/CFCBundle.h
+++ b/lldb/source/Host/macosx/cfcpp/CFCBundle.h
@@ -17,7 +17,7 @@ class CFCBundle : public CFCReleaser<CFBundleRef> {
CFCBundle(const char *path = NULL);
CFCBundle(CFURLRef url);
- virtual ~CFCBundle();
+ ~CFCBundle() override;
CFURLRef CopyExecutableURL() const;
diff --git a/lldb/source/Host/macosx/cfcpp/CFCData.h b/lldb/source/Host/macosx/cfcpp/CFCData.h
index ce8bfa2862f2e..a477be4ff475d 100644
--- a/lldb/source/Host/macosx/cfcpp/CFCData.h
+++ b/lldb/source/Host/macosx/cfcpp/CFCData.h
@@ -17,7 +17,7 @@ class CFCData : public CFCReleaser<CFDataRef> {
CFCData(CFDataRef data = NULL);
CFCData(const CFCData &rhs);
CFCData &operator=(const CFCData &rhs);
- virtual ~CFCData();
+ ~CFCData() override;
CFDataRef Serialize(CFPropertyListRef plist, CFPropertyListFormat format);
const uint8_t *GetBytePtr() const;
diff --git a/lldb/source/Host/macosx/cfcpp/CFCMutableArray.h b/lldb/source/Host/macosx/cfcpp/CFCMutableArray.h
index a951a3d43f7b3..66ad2b8790410 100644
--- a/lldb/source/Host/macosx/cfcpp/CFCMutableArray.h
+++ b/lldb/source/Host/macosx/cfcpp/CFCMutableArray.h
@@ -21,7 +21,7 @@ class CFCMutableArray : public CFCReleaser<CFMutableArrayRef> {
// the same array and
// just bump the ref
// count
- virtual ~CFCMutableArray();
+ ~CFCMutableArray() override;
CFIndex GetCount() const;
CFIndex GetCountOfValue(const void *value) const;
diff --git a/lldb/source/Host/macosx/cfcpp/CFCMutableDictionary.h b/lldb/source/Host/macosx/cfcpp/CFCMutableDictionary.h
index 4a422d765d42d..73457d323dfe0 100644
--- a/lldb/source/Host/macosx/cfcpp/CFCMutableDictionary.h
+++ b/lldb/source/Host/macosx/cfcpp/CFCMutableDictionary.h
@@ -16,7 +16,7 @@ class CFCMutableDictionary : public CFCReleaser<CFMutableDictionaryRef> {
// Constructors and Destructors
CFCMutableDictionary(CFMutableDictionaryRef s = NULL);
CFCMutableDictionary(const CFCMutableDictionary &rhs);
- virtual ~CFCMutableDictionary();
+ ~CFCMutableDictionary() override;
// Operators
const CFCMutableDictionary &operator=(const CFCMutableDictionary &rhs);
diff --git a/lldb/source/Host/macosx/cfcpp/CFCMutableSet.h b/lldb/source/Host/macosx/cfcpp/CFCMutableSet.h
index 49acfd4b115c4..3b8f93ad8144e 100644
--- a/lldb/source/Host/macosx/cfcpp/CFCMutableSet.h
+++ b/lldb/source/Host/macosx/cfcpp/CFCMutableSet.h
@@ -16,7 +16,7 @@ class CFCMutableSet : public CFCReleaser<CFMutableSetRef> {
// Constructors and Destructors
CFCMutableSet(CFMutableSetRef s = NULL);
CFCMutableSet(const CFCMutableSet &rhs);
- virtual ~CFCMutableSet();
+ ~CFCMutableSet() override;
// Operators
const CFCMutableSet &operator=(const CFCMutableSet &rhs);
diff --git a/lldb/source/Host/macosx/cfcpp/CFCString.h b/lldb/source/Host/macosx/cfcpp/CFCString.h
index b5ed79ed3bd38..e8d6dada7e09f 100644
--- a/lldb/source/Host/macosx/cfcpp/CFCString.h
+++ b/lldb/source/Host/macosx/cfcpp/CFCString.h
@@ -20,7 +20,7 @@ class CFCString : public CFCReleaser<CFStringRef> {
CFCString(const char *s, CFStringEncoding encoding = kCFStringEncodingUTF8);
CFCString(const CFCString &rhs);
CFCString &operator=(const CFCString &rhs);
- virtual ~CFCString();
+ ~CFCString() override;
const char *GetFileSystemRepresentation(std::string &str);
CFStringRef SetFileSystemRepresentation(const char *path);
diff --git a/lldb/source/Plugins/ABI/AArch64/ABIAArch64.h b/lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
index e771f69d7dbc7..52e42f1260a83 100644
--- a/lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
+++ b/lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
@@ -16,8 +16,8 @@ class ABIAArch64 : public lldb_private::MCBasedABI {
static void Initialize();
static void Terminate();
- virtual lldb::addr_t FixCodeAddress(lldb::addr_t pc) override;
- virtual lldb::addr_t FixDataAddress(lldb::addr_t pc) override;
+ lldb::addr_t FixCodeAddress(lldb::addr_t pc) override;
+ lldb::addr_t FixDataAddress(lldb::addr_t pc) override;
protected:
virtual lldb::addr_t FixAddress(lldb::addr_t pc, lldb::addr_t mask) {
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h b/lldb/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h
index 6313117c08d68..a9b2d4110ab2f 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h
+++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h
@@ -22,7 +22,7 @@ class ClangDeclVendor : public DeclVendor {
public:
ClangDeclVendor(DeclVendorKind kind) : DeclVendor(kind) {}
- virtual ~ClangDeclVendor() = default;
+ ~ClangDeclVendor() override = default;
using DeclVendor::FindDecls;
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.h b/lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.h
index a4de527e4512c..4abd16c5c3261 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.h
+++ b/lldb/source/Plugins/ExpressionParser/Clang/IRDynamicChecks.h
@@ -30,7 +30,7 @@ class ClangDynamicCheckerFunctions
ClangDynamicCheckerFunctions();
/// Destructor
- virtual ~ClangDynamicCheckerFunctions();
+ ~ClangDynamicCheckerFunctions() override;
static bool classof(const DynamicCheckerFunctions *checker_funcs) {
return checker_funcs->GetKind() == DCF_Clang;
diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h b/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
index bac7496a50e61..f897b78e669b7 100644
--- a/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
+++ b/lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
@@ -64,7 +64,7 @@ class PlatformAppleSimulator : public PlatformDarwin {
CoreSimulatorSupport::DeviceType::ProductFamilyID kind,
bool force, const ArchSpec *arch);
- virtual ~PlatformAppleSimulator();
+ ~PlatformAppleSimulator() override;
llvm::StringRef GetPluginName() override {
return m_plugin_name.GetStringRef();
diff --git a/lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h b/lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h
index 6c30b8b1d0adc..c135c53348d60 100644
--- a/lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h
+++ b/lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h
@@ -50,7 +50,7 @@ class PlatformDarwinKernel : public PlatformDarwin {
PlatformDarwinKernel(LazyBool is_ios_debug_session);
- virtual ~PlatformDarwinKernel();
+ ~PlatformDarwinKernel() override;
llvm::StringRef GetPluginName() override { return GetPluginNameStatic(); }
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.h b/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.h
index 4981b42008dbb..c70f7de5bdcf5 100644
--- a/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.h
+++ b/lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.h
@@ -79,7 +79,7 @@ class CommunicationKDP : public lldb_private::Communication {
// Constructors and Destructors
CommunicationKDP(const char *comm_name);
- virtual ~CommunicationKDP();
+ ~CommunicationKDP() override;
bool SendRequestPacket(const PacketStreamType &request_packet);
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm.h b/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm.h
index 35ae0d03e2bbd..5e8f5fad133e2 100644
--- a/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm.h
+++ b/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm.h
@@ -17,7 +17,7 @@ class RegisterContextKDP_arm : public RegisterContextDarwin_arm {
public:
RegisterContextKDP_arm(ThreadKDP &thread, uint32_t concrete_frame_idx);
- virtual ~RegisterContextKDP_arm();
+ ~RegisterContextKDP_arm() override;
protected:
int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm64.h b/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm64.h
index be387d69c6bcb..d88d03e273fe3 100644
--- a/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm64.h
+++ b/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_arm64.h
@@ -18,7 +18,7 @@ class RegisterContextKDP_arm64 : public RegisterContextDarwin_arm64 {
public:
RegisterContextKDP_arm64(ThreadKDP &thread, uint32_t concrete_frame_idx);
- virtual ~RegisterContextKDP_arm64();
+ ~RegisterContextKDP_arm64() override;
protected:
int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_i386.h b/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_i386.h
index 9ee6af7cc573d..04868e96191fd 100644
--- a/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_i386.h
+++ b/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_i386.h
@@ -17,7 +17,7 @@ class RegisterContextKDP_i386 : public RegisterContextDarwin_i386 {
public:
RegisterContextKDP_i386(ThreadKDP &thread, uint32_t concrete_frame_idx);
- virtual ~RegisterContextKDP_i386();
+ ~RegisterContextKDP_i386() override;
protected:
int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_x86_64.h b/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_x86_64.h
index 3d5139d0b613d..8e837c0630ab0 100644
--- a/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_x86_64.h
+++ b/lldb/source/Plugins/Process/MacOSX-Kernel/RegisterContextKDP_x86_64.h
@@ -17,7 +17,7 @@ class RegisterContextKDP_x86_64 : public RegisterContextDarwin_x86_64 {
public:
RegisterContextKDP_x86_64(ThreadKDP &thread, uint32_t concrete_frame_idx);
- virtual ~RegisterContextKDP_x86_64();
+ ~RegisterContextKDP_x86_64() override;
protected:
int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
diff --git a/lldb/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.h b/lldb/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.h
index 7f13fcbeb4a55..08e007fb3f9b9 100644
--- a/lldb/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.h
+++ b/lldb/source/Plugins/Process/MacOSX-Kernel/ThreadKDP.h
@@ -20,7 +20,7 @@ class ThreadKDP : public lldb_private::Thread {
public:
ThreadKDP(lldb_private::Process &process, lldb::tid_t tid);
- virtual ~ThreadKDP();
+ ~ThreadKDP() override;
void RefreshStateAfterStop() override;
diff --git a/lldb/source/Plugins/Process/Utility/RegisterContextMach_arm.h b/lldb/source/Plugins/Process/Utility/RegisterContextMach_arm.h
index 1ceca65c97c37..fedd0062c99c7 100644
--- a/lldb/source/Plugins/Process/Utility/RegisterContextMach_arm.h
+++ b/lldb/source/Plugins/Process/Utility/RegisterContextMach_arm.h
@@ -16,7 +16,7 @@ class RegisterContextMach_arm : public RegisterContextDarwin_arm {
RegisterContextMach_arm(lldb_private::Thread &thread,
uint32_t concrete_frame_idx);
- virtual ~RegisterContextMach_arm();
+ ~RegisterContextMach_arm() override;
protected:
int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
diff --git a/lldb/source/Plugins/Process/Utility/RegisterContextMach_i386.h b/lldb/source/Plugins/Process/Utility/RegisterContextMach_i386.h
index da5411eb2de24..8bdac083863d4 100644
--- a/lldb/source/Plugins/Process/Utility/RegisterContextMach_i386.h
+++ b/lldb/source/Plugins/Process/Utility/RegisterContextMach_i386.h
@@ -16,7 +16,7 @@ class RegisterContextMach_i386 : public RegisterContextDarwin_i386 {
RegisterContextMach_i386(lldb_private::Thread &thread,
uint32_t concrete_frame_idx);
- virtual ~RegisterContextMach_i386();
+ ~RegisterContextMach_i386() override;
protected:
int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
diff --git a/lldb/source/Plugins/Process/Utility/RegisterContextMach_x86_64.h b/lldb/source/Plugins/Process/Utility/RegisterContextMach_x86_64.h
index c131c8282bd22..99841a8e9a8d2 100644
--- a/lldb/source/Plugins/Process/Utility/RegisterContextMach_x86_64.h
+++ b/lldb/source/Plugins/Process/Utility/RegisterContextMach_x86_64.h
@@ -17,7 +17,7 @@ class RegisterContextMach_x86_64 : public RegisterContextDarwin_x86_64 {
RegisterContextMach_x86_64(lldb_private::Thread &thread,
uint32_t concrete_frame_idx);
- virtual ~RegisterContextMach_x86_64();
+ ~RegisterContextMach_x86_64() override;
protected:
int DoReadGPR(lldb::tid_t tid, int flavor, GPR &gpr) override;
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
index 17ee4130dc346..5f7944bf8407b 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
@@ -241,7 +241,7 @@ class GDBRemoteCommunicationServerLLGS
static std::string XMLEncodeAttributeValue(llvm::StringRef value);
- virtual std::vector<std::string> HandleFeatures(
+ std::vector<std::string> HandleFeatures(
const llvm::ArrayRef<llvm::StringRef> client_features) override;
private:
diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
index 8f379d4c18485..76ad47f2907e6 100644
--- a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
+++ b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
@@ -636,7 +636,7 @@ class PythonException : public llvm::ErrorInfo<PythonException> {
const char *toCString() const;
PythonException(const char *caller = nullptr);
void Restore();
- ~PythonException();
+ ~PythonException() override;
void log(llvm::raw_ostream &OS) const override;
std::error_code convertToErrorCode() const override;
bool Matches(PyObject *exc) const;
diff --git a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h
index f2ac30627a5b2..7c2fadc21d427 100644
--- a/lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h
+++ b/lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPythonInterface.h
@@ -25,7 +25,7 @@ class ScriptInterpreterPythonImpl;
class ScriptedPythonInterface : virtual public ScriptedInterface {
public:
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
- virtual ~ScriptedPythonInterface() = default;
+ ~ScriptedPythonInterface() override = default;
protected:
template <typename T = StructuredData::ObjectSP>
More information about the lldb-commits
mailing list