[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D128069#3592733 <https://reviews.llvm.org/D128069#3592733>, @dmlary wrote:

> I went through the existing tests for SBSection, and there is only one test case for all the getters & props, and that is for `target_byte_size`.  Based on that lack, and the simplicity of the getter, I didn't think a test case was warranted here.

I'm less concerned about the getter and the property and more about the underlying functionality. It doesn't look like it's being tested, and adding it to the SB API allows to change that.

> If the reviewers feel a test is necessary here, I can definitely add one.

Yes, unless there's a good reason not too, every change should be accompanied by a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128069/new/

https://reviews.llvm.org/D128069