[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

[David M. Lary via lldb-commits]

On Fri, Jun 17, 2022 at 14:32 Jonas Devlieghere via Phabricator
<reviews at reviews.llvm.org> wrote:
>
> JDevlieghere added a comment.
>
> In D128069#3592733 <https://reviews.llvm.org/D128069#3592733>, @dmlary wrote:
>
> > I went through the existing tests for SBSection, and there is only one test case for all the getters & props, and that is for `target_byte_size`.  Based on that lack, and the simplicity of the getter, I didn't think a test case was warranted here.
>
> I'm less concerned about the getter and the property and more about the underlying functionality. It doesn't look like it's being tested, and adding it to the SB API allows to change that.

Just to clarify, are you asking me to add a test for the underlying
functionality, `Section.GetLog2Align()`?  Or is the goal to add the
test at the SBSection level to ensure we detect if someone ever
changes the underlying api?