[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTMultiCoreDecoder.h:65
 
-  TraceIntelPT &m_trace;
-  std::set<lldb::core_id_t> m_cores;
+  TraceIntelPT *m_trace;
   std::set<lldb::tid_t> m_tids;
----------------
wallace wrote:
> jj10306 wrote:
> > why are we storing a pointer now if the constructor is still passing in a ref?
> We have two options: store a pointer or a a weak pointer. We can't use a reference variable because the new version of the code requires the multicore decoder to have a copy constructor (Optional is the one asking for that).
> So I'm changing this now to use weak_pointers to make it more c++ idiomatic.
Addressed in https://reviews.llvm.org/D127881


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127456/new/

https://reviews.llvm.org/D127456