[Lldb-commits] [PATCH] D122980: make ConstStringTable use std::unordered_map rather than std::map

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Apr 2 09:04:58 PDT 2022


JDevlieghere added a comment.

I feel like this came up in the past and there was a reason an unordered map couldn't work? Maybe I'm confusing this with something else. Added Pavel as he would certainly know.

Could we use a `llvm::DenseMap` here, as it's supposedly even faster than its STL counterpart?

(Adding myself as a reviewer too so this shows up in my review queue)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122980/new/

https://reviews.llvm.org/D122980



More information about the lldb-commits mailing list