[Lldb-commits] [PATCH] D122867: [trace][intel pt] Handle better tsc in the decoder

[Jakob Johnson via Phabricator via lldb-commits]

jj10306 added inline comments.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:236-238
+  /// Notify this class that the last added instruction or error has
+  /// an associated TSC.
+  void ReportTscForLastInstruction(uint64_t tsc);
----------------
nit: When I initially read "Report" it made me think that the last TSC was being logged or reported to something else. Since all this method does is record the tsc of the last instruction, potentially "Record" is a better name. This is purely my opinion so feel free to keep it as is or change it (:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122867/new/

https://reviews.llvm.org/D122867