[Lldb-commits] [PATCH] D122898: [lldb] Move host platform implementations into the base class

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 1 05:46:39 PDT 2022

labath created this revision.
labath added reviewers: JDevlieghere, jingham.
Herald added a project: All.
labath requested review of this revision.
Herald added a project: LLDB.

About half of our host platform code was implemented in the Platform
class, while the rest was it RemoteAwarePlatform. Most of the time, this
did not matter, as nearly all our platforms are also
RemoteAwarePlatforms. It makes a difference for PlatformQemu, which
descends directly from the base class (as it is local-only).

This patch moves all host code paths into the base class, and marks
PlatformQemu as a "host" platform so it can make use of them (it sounds
slightly strange, but that is consistent with what the apple simulator
platforms are doing). Not all of the host implementations make sense for
this platform, but it can always override those that don't.

I add some basic tests using the platform file apis to exercise this

  rG LLVM Github Monorepo



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122898.419730.patch
Type: text/x-patch
Size: 15275 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220401/26cf6ad7/attachment-0001.bin>

More information about the lldb-commits mailing list