[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

[Alisamar Husain via Phabricator via lldb-commits]

zrthxn updated this revision to Diff 419656.
zrthxn edited the summary of this revision.
zrthxn added a comment.

The difference in memory usage is appreciable with large number of instructions, as shown below

  # Before (with current metrics, total memory does not include raw trace size)
    Raw trace size: 2048 KiB
    Total number of instructions: 900004
    Total approximate memory usage: 56143.10 KiB
    Average memory usage per instruction: 63.87 bytes

  # After
    Raw trace size: 2048 KiB
    Total number of instructions: 900004
    Total approximate memory usage: 42187.69 KiB
    Average memory usage per instruction: 48.00 bytes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122603/new/

https://reviews.llvm.org/D122603

Files:
  lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp
  lldb/source/Plugins/Trace/intel-pt/DecodedThread.h
  lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceCursorIntelPT.h
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
  lldb/test/API/commands/trace/TestTraceDumpInfo.py
  lldb/test/API/commands/trace/TestTraceLoad.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122603.419656.patch
Type: text/x-patch
Size: 15654 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220401/bc8bf432/attachment.bin>