[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 31 15:35:55 PDT 2022


wallace added inline comments.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:145
+  private:
+    friend class DecodedThread;
+
----------------
jj10306 wrote:
> nit: No need to friend the enclosing class since C++11 - https://en.cppreference.com/w/cpp/language/nested_types
TIL!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122603/new/

https://reviews.llvm.org/D122603



More information about the lldb-commits mailing list