[Lldb-commits] [PATCH] D114520: [lldb/gdb-remote] Ignore spurious ACK packets

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationTest.cpp:56
       {{"$foobar#79"}, {"foobar"}},
-      {{"$}}#fa"}, {"]"}},
-      {{"$x*%#c7"}, {"xxxxxxxxx"}},
----------------
mgorny wrote:
> I don't get how this is relevant to the patch in question.
It's not directly related, but in the process of adding comments to the test cases I realized that this test case doesn't make sense (there's no need to escape a `]`), so I changed into what the author probably meant to test (escaping a `}`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114520/new/

https://reviews.llvm.org/D114520