[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid accepted this revision.
omjavaid added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Target/Process.cpp:5854
+  if (auto abi = GetABI()) {
+    // TODO: can we always assume data addresses here?
+    load_addr = abi->FixDataAddress(load_addr);
----------------
Yes this is ok for now as both Data and Code masks are same in case of Linux. If anything changes in future we ll take care of that at that time. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102757/new/

https://reviews.llvm.org/D102757