[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/source/Target/Process.cpp:5854
+  if (auto abi = GetABI()) {
+    // TODO: can we always assume data addresses here?
+    load_addr = abi->FixDataAddress(load_addr);
----------------
omjavaid wrote:
> Yes this is ok for now as both Data and Code masks are same in case of Linux. If anything changes in future we ll take care of that at that time. 
Cool. I was also thinking that if they were different you could just apply both masks. Since the virtual address size will be the same for either type of pointer.

I'll remove this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102757/new/

https://reviews.llvm.org/D102757