[Lldb-commits] [PATCH] D99653: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

Wed Mar 31 08:55:04 PDT 2021

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Looks good as long as we fix to DWARFUnit::GetRnglist() to not return a full copy of the "llvm::Optional<llvm::DWARFDebugRnglistTable>" each time it is called.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:498-500
+llvm::Optional<llvm::DWARFDebugRnglistTable> DWARFUnit::GetRnglist() {
+  return m_rnglist_table;
+}
----------------
Return "const llvm::Optional<llvm::DWARFDebugRnglistTable> &" to avoid making a copy.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99653/new/

https://reviews.llvm.org/D99653