[Lldb-commits] [PATCH] D93657: [lldb] Ad os_signpost support to `lldb_private::Timer`

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Utility/Timer.cpp:62
     : m_category(category), m_total_start(std::chrono::steady_clock::now()) {
+  Signposts->startInterval(this, m_category.GetName());
   TimerStack &stack = GetTimerStackForCurrentThread();
----------------
mib wrote:
> Did you mean `startTimerInterval` here ? I don't see `startInterval` in the llvm headers ...
No, those are instances of `llvm::Timer`. If you look at the "Stack" you can see this depends on D93655 which changes the Signpost interface to work with arbitrary objects.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93657/new/

https://reviews.llvm.org/D93657