[Lldb-commits] [PATCH] D93657: [lldb] Ad os_signpost support to `lldb_private::Timer`

[Med Ismail Bennani via Phabricator via lldb-commits]

mib accepted this revision.
mib added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Utility/Timer.cpp:62
     : m_category(category), m_total_start(std::chrono::steady_clock::now()) {
+  Signposts->startInterval(this, m_category.GetName());
   TimerStack &stack = GetTimerStackForCurrentThread();
----------------
Did you mean `startTimerInterval` here ? I don't see `startInterval` in the llvm headers ...


================
Comment at: lldb/source/Utility/Timer.cpp:89
 
+  Signposts->endInterval(this, m_category.GetName());
+
----------------
Same here with `llvm::SignpostEmitter::endTimerInterval`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93657/new/

https://reviews.llvm.org/D93657