[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

[Frederic Riss via Phabricator via lldb-commits]

friss added a comment.

This is the generic part of https://reviews.llvm.org/D83023

I modified to existing unittests to load their binary directly from memory, one ELF, one Mach-O. I tried to modify a PECOFF test to, but ObjectFilePECoff requires the file to be on the filesystem as it reopens it to create an LLVM PECoff object. I'm not sure about the testing strategy here. Should this just be a dedicated test instead, and remove the ugly `InMemory` thing that this patch adds to TestFile?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83512/new/

https://reviews.llvm.org/D83512