[Lldb-commits] [PATCH] D82732: WIP: Use SB APIs in CommandObjects
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 8 02:34:45 PDT 2020
teemperor added inline comments.
================
Comment at: lldb/include/lldb/API/SBBreakpoint.h:142
+
+ lldb::BreakpointSP GetSP() const;
+
----------------
I assume this is WIP code and we already told you that, but we can't expose the internal `lldb_private::*` classes (or their `lldb::*SP` typedef). So this needs to be replaced with SB API patches.
================
Comment at: lldb/include/lldb/API/SBTarget.h:69
+ bool IsProcessValid() const;
+
----------------
This should rather be a `IsAlive` function in SBProcess.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82732/new/
https://reviews.llvm.org/D82732
More information about the lldb-commits
mailing list