[Lldb-commits] [PATCH] D67538: [Reproducer] Include the this pointer in the API log.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added a reviewer: jingham.
Herald added a subscriber: abidh.
Herald added a project: LLDB.

The new centralized way of doing API logging through the reproducer
macros is lacking a way to easily correlate instances of API objects.
Logging the this pointer makes that significantly easier. For methods
this is now always passed as the first argument, similar to the self
argument in Python.

This patch also adds a test case for API logging, which uncovered that
we were not quoting strings.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D67538

Files:
  lldb/include/lldb/Utility/ReproducerInstrumentation.h
  lldb/packages/Python/lldbsuite/test/api/log/TestAPILog.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67538.220044.patch
Type: text/x-patch
Size: 4918 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190913/b643512c/attachment.bin>