[Lldb-commits] [PATCH] D67523: [Reproducer] Move GDB packet struct into the reproducer. (NFC)

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D67523#1668608 <https://reviews.llvm.org/D67523#1668608>, @jingham wrote:

> It seems weird to me to have the GDBRemotePacket class live in the repro namespace.  There's nothing particularly Reproducer specific about it, and it clearly gets used outside the reproducer as well.  Wouldn't it make more sense to have this in Utils?


Yep, I agree, and I considered alternatives but couldn't find a better solution. It's seems too specific for a utility class in itself and doesn't belong in Core or Target either. It really should be part of the GDB plugin, but then we can't access it without layering violations from Command...


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67523/new/

https://reviews.llvm.org/D67523